[SPARK-54120] Update assertGeneratedCRDMatchesHelmChart to include diff #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request?
Enhance existing test assertGeneratedCRDMatchesHelmChart to give diff upon failure
### Why are the changes needed?
For better readability.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Self-contained upon success & manually tested failure scenario - e.g. remove some fields from CRD inhelm repo, the test would fail with message like
```
* What went wrong:
Execution failed for task ':spark-operator-api:assertGeneratedCRDMatchesHelmChart'.
> Generated CRD yaml does not match the staged version in Helm Chart, please keep the chart updated.
=== SparkApplication CRD Differences ===
--- /dev/fd/63 2025-10-31 14:33:55
+++ /dev/fd/62 2025-10-31 14:33:55
@@ -6355,11 +6355,6 @@
properties:
currentAttemptSummary:
properties:
- attemptInfo:
- properties:
- id:
- type: integer
- type: object
stateTransitionHistory:
additionalProperties:
properties:
=== SparkCluster CRD Differences ===
--- /dev/fd/63 2025-10-31 14:33:55
+++ /dev/fd/62 2025-10-31 14:33:55
@@ -7218,8 +7218,6 @@
type: string
lastTransitionTime:
type: string
- message:
- type: string
type: object
type: object
type: object
```
Which gives a more clear indication about the exact failure
### Was this patch authored or co-authored using generative AI tooling?
No
Contributor
Author
|
cc @peter-toth for review - thanks a lot in advance! |
peter-toth
approved these changes
Nov 1, 2025
Contributor
|
Thank you @jiangzho, merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enhance existing test assertGeneratedCRDMatchesHelmChart to give diff upon failure
Why are the changes needed?
For better readability.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Self-contained upon success & manually tested failure scenario - e.g. remove some fields from CRD inhelm repo, the test would fail with message like
Which gives a more clear indication about the exact failure
Was this patch authored or co-authored using generative AI tooling?
No